MAINT use properly the metadata from OpenML #29411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Jul 8, 2024
Comment on lines
+126
to
+127
| OpenML URL that will be accessed. We parse the URL to get the path and | ||
| replicate the tree structure on the local cache. |
There was a problem hiding this comment.
Suggested change
| OpenML URL that will be accessed. We parse the URL to get the path and | |
| replicate the tree structure on the local cache. | |
| URL of an OpenML file to be downloaded and cached locally. The path component | |
| of the URL is used to replicate the tree structure as sub-folders of the local | |
| cache folder. |
| @@ -156,6 +155,7 @@ def is_gzip_encoded(_fsrc): | |||
| return gzip.GzipFile(fileobj=fsrc, mode="rb") | |||
| return fsrc | |||
|
|
|||
| openml_path = urlparse(url).path[1:] # remove leading slash | |||
There was a problem hiding this comment.
Safer and more explicit this way:
Suggested change
| openml_path = urlparse(url).path[1:] # remove leading slash | |
| openml_path = urlparse(url).path.lstrip("/") # remove the leading slash |
|
Superseded by #30708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve the code in
_openml.pyto use thejsonfile from OpenML. In this case, it helps at transitioning from ARFF file to parquet file. It also makes it easier for transitioning from v1 API to the future v2.