Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Add note on cv splits in CalibratedClassifierCV missing classes #29449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

Follows on from #29000

What does this implement/fix? Explain your changes.

Add note that when a cv split is missing a class in CalibratedClassifierCV, the predicted probability defaults to 0 for that 'calibrated classifier'

Any other comments?

Copy link

github-actions bot commented Jul 10, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8872e8d. Link to the linter CI: here

@lucyleeow
Copy link
Member Author

ping @glemaitre

@glemaitre glemaitre self-requested a review July 22, 2024 12:56
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is already an improvement. Let's merge.

Thanks @lucyleeow

@glemaitre glemaitre merged commit 24b581b into scikit-learn:main Jul 22, 2024
30 checks passed
@lucyleeow lucyleeow deleted the doc_calbclass branch July 22, 2024 22:37
MarcBresson pushed a commit to MarcBresson/scikit-learn that referenced this pull request Sep 2, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants