-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Fix changed return type dtype for array API #29488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@betatim I think the CUDA CI is currently failing because the array-api-strict is not updated to the latest version in the CUDA CI. Either we need to update the version or change how we handle maximum as its available in the latest version but not in prior ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @betatim
I thought that updating the lockfile (as I did in this PR) would not fix it, but it seems like it did? I think supporting more than the latest version of The unsovled mystery for me is why the array-api-strict related error went away in this PR? What change did I make that lead to a newer version of it being installed? |
I agree with you and I think we went with the implementation based on considering the latest version of the api. I think the error is now fixed because the lock file is updated and the supported version in the lock file is now == 2.0.1. Previously array-api-strict was == 1.1.1 in the lock file and that version does not support the maximum function. |
Ergh. I looked at the lockfile diff twice and couldn't spot @lesteve should we merge this or #29373 (comment) and then this. Or something else completely? |
Let's merge this and close #29373. |
This (attempts to) fixes the failure in #29373 (comment)
The failing test shows that the returned array has a different dtype from the input.