ENH Add Array API compatibility to 'auc' #29755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
reviewed
Nov 13, 2024
Comment on lines
+1051
to
+1052
| def _trapezoid(y, x=None, dx=1.0, axis=None): | ||
| """Partial (one-dimensional) port of scipy.trapezoid to support the Array API.""" |
There was a problem hiding this comment.
See also scipy/scipy#21524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Adds to #26024
What does this implement/fix? Explain your changes.
The AUC metric is made to be array api compatible. The original implementation uses np.diff, which is not part of the array api standard. Here, it is a simple difference between two neighboring array elements in a one-dimensional array and thus is replaced by a simple difference of two array slices.
Furthermore, a one-dimensional version of scipy.integrate.trapezoid is implemented to be used in 'auc'.
Any other comments?
This PR includes the changes from #29519 and should be merged after it. The changes from #29519 are in a single commit which can be removed before this PR is merged.