-
-
Notifications
You must be signed in to change notification settings - Fork 26.4k
FIX accept infinite C in SVC and SVR #29780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OmarManzoor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks @glemaitre
I don't think the CI failures look related as they seem to be occurring elsewhere too.
|
Yep the failure is tracked there: #29771 |
|
Not sure this is worth doing to be honest ( If we do it we may as well do it for |
|
I'll do for the other class.
If it would not be a regression and that we never tolerated it, I would not make the change. But the fact that we introduced this small regression is a bit annoying :) |
|
And it's good to be able to explore the unregularized limit if the underlying solver can support it. Although in practice, it should be very similar to |
ogrisel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@lesteve I quickly check what happen when setting So this is probably not a good idea to tolerate this for both |
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
closes #29772
Solve a regression in
SVCandSVRwere we previously acceptedC=float("inf").