Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC remove example showing a single image from digits dataset #29931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 28, 2024
Merged

DOC remove example showing a single image from digits dataset #29931

merged 6 commits into from
Sep 28, 2024

Conversation

saldanhad
Copy link
Contributor

Reference Issues/PRs

Part of #27151

What does this implement/fix? Explain your changes.

Deleted plot_digits_last_image.py to remove the The Digit Dataset example

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a1522b3. Link to the linter CI: here

@saldanhad
Copy link
Contributor Author

@ArturoAmorQ, I believe removing the example is better to keep thing simple, however if you would like me to add The Digit Dataset at the starting part of the Digits Classification Exercise, I would be happy to edit this PR, PLMK.

@saldanhad saldanhad marked this pull request as draft September 27, 2024 17:28
@saldanhad saldanhad marked this pull request as ready for review September 27, 2024 17:33
@glemaitre glemaitre self-requested a review September 28, 2024 18:49
@glemaitre glemaitre changed the title DOC: Suppress The Digit Dataset example DOC remove example showing a single image from digits dataset Sep 28, 2024
glemaitre
glemaitre reviewed Sep 28, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough for this PR.
LGTM

Thanks @saldanhad

@glemaitre glemaitre merged commit d99b3ce into scikit-learn:main Sep 28, 2024
32 checks passed
@saldanhad saldanhad deleted the digits branch September 28, 2024 18:58
@ArturoAmorQ ArturoAmorQ mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saldanhad @glemaitre