DOC Merge Lasso Lasso-LARS and ElasticNet examples together #29955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
I push directly in the branch because it would have been difficult to ask the changes from the review process. I made the following changes:
- make sure that the links in the user guide are changed to point to the right images and examples
- better merge the two examples to have a better reading experience and rework the description of the example
- redirect previous 2 links to the new example name
I trigger a doc build to check that we don't have dead link (it should be picked by sphinx warnings in a full build).
If everything is fine, we can merge this PR.
I think that we should revisit this example to have a much better description and explanations of the results:
- we should explain the difference between Lasso and Lasso-LARS and refer to the following paper: https://hastie.su.domains/Papers/LARS/LeastAngle_2002.pdf
- we should explain the difference between the lasso and elastic net
- we should discuss the positive constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part of #27151
What does this implement/fix? Explain your changes.
Lasso and Elastic Net merged with Lasso path using Lars example.