Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC remove color quantization K-means example #29961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

DOC remove color quantization K-means example #29961

merged 1 commit into from
Oct 14, 2024

Conversation

glemaitre
Copy link
Member

Partially addressing #27151

Removing an example performing color quantization. The reason for removing this example:

I removed the example containing less details and that is only code oriented.

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4f4a362. Link to the linter CI: here

jeremiedbb
jeremiedbb approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I liked this example :'( but fair.
The alternative example is not so great either though. The conclusion is that in that situation it does not work. We should consider, in a later PR, reworking it to have make it actually work.

@ArturoAmorQ
Copy link
Member

ArturoAmorQ commented Oct 3, 2024 •
edited
Loading

I also like that example :( I was thinking that this example can be reworked to showcase silhouette analysis and then merge it with Selecting the number of clusters with silhouette analysis on KMeans clustering. It could be nice to have a visual intuition (but probably not with china.jpg) of the resulting number of clusters.

@jeremiedbb
Copy link
Member

I was thinking that this example can be reworked to showcase silhouette analysis

To me, it's a really different use case. Silhouette analysis is used to find an "optimal" number of cluster, while in the china example the number of clusters is chosen ahead of time based on a technical constraint.

@glemaitre
Copy link
Member Author

Basically, I think that we can drop this example and rework the current racoon example where the story telling is not close to the truth.

@adrinjalali adrinjalali merged commit 48ef3ba into scikit-learn:main Oct 14, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Documentation module:cluster
Projects
Documentation improvement
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glemaitre @ArturoAmorQ @jeremiedbb @adrinjalali