DOC: Clarify the sign in log marginal likelihood plot. #30273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virchan
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
The example is indeed plotting the negative of the log-marginal-likelihood:
Thanks for catching that, @viktor765!
Cc: @adrinjalali
adrinjalali
approved these changes
Nov 19, 2024
|
Thanks for the PR @viktor765 , and thanks for the review @virchan |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 4, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This clarifies that the plot of the log-marginal-likelihood is done with a minus sign. The title of the plot now reflects that together with one place in the text, which previously indicated the wrong sign.
Any other comments?