MAINT add deprecation for transition to new developer API tools #30299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @ogrisel @adrinjalali @jeremiedbb This part is quite easy and can be merged without the tags. |
adrinjalali
approved these changes
Nov 18, 2024
Co-authored-by: Adrin Jalali <[email protected]>
|
I also think one cycle is enough for these private methods. |
|
I'm not against this solution. We warn for 1.6, and we remove in 1.7. |
jeremiedbb
approved these changes
Nov 19, 2024
glemaitre
commented
Nov 19, 2024
glemaitre
commented
Nov 19, 2024
|
Move the version of deprecation to 1.7. Enabling auto-merge. |
glemaitre
commented
Nov 19, 2024
glemaitre
commented
Nov 19, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 4, 2024
…it-learn#30299) Co-authored-by: Adrin Jalali <[email protected]>
jeremiedbb
pushed a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Adrin Jalali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #30298
This PR avoid the breaking changes that we introduced by moving tools and changing the name.
Instead, it raises a deprecation warning to give a bit more time for user to adapt their code.
TODO
_validate_data_check_feature_name_check_n_features