DOC Enable the canonical link for docs #30725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I visited a few more random pages (main page, user guide page, API reference and example gallery) on the docs preview and they all contain the right canonical link. |
lesteve
reviewed
Jan 28, 2025
|
Looks good, thanks! I pushed a tweak to the comment and enabled auto-merge. Feel free to improve it further of course! This will need to be back-ported to 1.5.X and 1.6.X branch for this to have an effect on the real world. |
lesteve
approved these changes
Jan 28, 2025
betatim
added a commit
to betatim/scikit-learn
that referenced
this pull request
Jan 28, 2025
Co-authored-by: Loïc Estève <[email protected]>
betatim
added a commit
to betatim/scikit-learn
that referenced
this pull request
Jan 28, 2025
Co-authored-by: Loïc Estève <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8958
This is an attempt to get the
<link rel=canonical />tag back in our docs pages. In a local build this seems to fix the issue and generate a correct URL.Waiting to see what the rendered docs do. I am not sure I know what (un)expected consequences this could have/which pages we'd need to look at to make sure the generated link is correct for all of them.
cc @lesteve