DOC Update Lasso class docstring _coordinate_descent.py #30911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Feb 28, 2025
|
@goutam-kul, could you please add "Fixes #30893" under the "Reference Issues/PRs" section of the PR description? This will automatically close the issue when the PR is merged. |
|
@virchan Mentioned the issue number in the description, thanks for the input, I will keep this in mind for my next PRs. |
OmarManzoor
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Fixes #30893
As mentioned in #30893, in the Lasso class documentation there was an incorrect suggestion that it also supports arrays input when it doesn't.
The documentation line "If an array is passed, penalties are assumed to be specific to the targets. Hence they must correspond in number." in the Lasso docs needed to be removed or the implementation needed to updated.
For quick fix I have remove the line from the documentation, as in #11566 a good discussion was done on this topic but no conclusion was formed.