Fix KBinsDiscretizer uniform strategy : wrong bin assignment caused by floating point errors when using uniform strategy
#30962
+72
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ogrisel, PTAL if this fix looks good to you? Thanks. |
|
Hi @thomasjpfan , could you please take a look at these changes? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes: #30924
What does this implement/fix? Explain your changes.
Fix precision issues in
KBinsDiscretizerwhen using the "uniform" strategy by replacingnp.linspace(which relies on floating-point arithmetic) withdecimalfor exact bin edge computation.Previously, floating-point rounding errors could accumulate, leading to slight inaccuracies in bin edge calculations.
Changes:-
np.linspaceand usesdecimalfor edge computation when usinguniformstrategy.test_kbinsdiscretizer_uniform_strategyAny other comments?
Any suggestions or feedback is highly appreciated. Thanks.