Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC add link to plot_det example in _ranking.py #30977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ndaters
Copy link

@ndaters ndaters commented Mar 12, 2025

[DOC] Add link to plot_det example in _ranking.py

This PR adds a reference link to the det example in sklearn/metrics/_ranking.py

Changes:

Added a direct link for the plot_det example

Testing:

Checked updates meet documentation guidelines
Ran local tests successfully.

Towards #30621.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3c1eb17. Link to the linter CI: here

Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ndaters,

thanks for your contribution. In this case to be honest, I would not add the link to the example at all. It is already in the Example Gallery that stats just the next line and we don't want to double reference examples in the same place. Also, when we click on the link to the User Guide in the beginning of the docstring for det_curve(), the same example also already pops up. Thus this example does not need to be further linked.

Your contribution is still very valuable though, because it brought this to our attention. As mentioned in the issue description, not all examples need to be linked and we assume that 30% don't need to.

I will leave a note saying it was checked and decided not to be linked.

I hope this doesn't feel too frustrating for your first contribution.
Thanks again, and please feel free to work on the next example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants