Fix: AttributeError in str_escape when handling numpy.int64 in sklearn.tree._export.py in /sklearn/tree/_export.py #31036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c952ea to
5a7a615
Compare
5a7a615 to
d595a59
Compare
Contributor
Author
|
Hello I noticed that the changelog check is failing, and I wanted to confirm whether a changelog entry is required for this PR or if it can be bypassed. Please let me know how you'd like me to proceed. Thanks for your time! |
adrinjalali
approved these changes
Sep 23, 2025
Member
adrinjalali
left a comment
There was a problem hiding this comment.
LGTM. @OmarManzoor this should be a quick review.
OmarManzoor
approved these changes
Sep 23, 2025
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @guilhermecsnpeixoto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates export_graphviz to raise a ValueError when receiving non-string feature names, such as numpy.int64, instead of causing an AttributeError. This follows the suggestion in issue #30834, ensuring clearer error handling and guidance for users.
Reference Issues/PRs
Fixes #30834
What does this implement/fix? Explain your changes.
Implemented parameter verification, raising valueError for invalid inputs as suggested in the respective issue.
Any other comments?
No.