Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT Use find_program in meson.build for tempita step #31058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Mar 24, 2025
Merged

MNT Use find_program in meson.build for tempita step #31058

merged 35 commits into from
Mar 24, 2025

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Mar 24, 2025

Taken out of #29791.

Follow what Numpy and scipy are doing, see scipy/scipy#20121 for scipy.

@agriyakhetarpal
Test Pyodide 0.27.0a2
22aa88f
@agriyakhetarpal
Try to fix js.process ModuleNotFoundError
37884ac
@agriyakhetarpal
Install Pyodide JS library for testing
d9d43fa
@agriyakhetarpal
Skip tests that require a network (with pooch)
776e2c9
@agriyakhetarpal
Fix Pyodide NPM installation
85d644d
@agriyakhetarpal
Don't explicitly set xbuildenv version
527c151
@agriyakhetarpal
Install pyodide-cli
5ba18f0
@agriyakhetarpal
Import sklearn, try testing without --pyargs
d04b38e
@agriyakhetarpal
Reinstall xbuildenv manually, install npm-pyodide in doc/
d6708a6
@agriyakhetarpal
Add TODO note about Azure
2760c38
@agriyakhetarpal
Set PYTHONVERBOSE and PYTHONDEBUG for debugging
16267d7
@agriyakhetarpal
Switch to maint_tools/ instead of doc/
961a9d4
@agriyakhetarpal
Clean up changes, use --pyargs
ee3228e
@agriyakhetarpal
Fix a typo: paralell ➡️ parallel
383bf7e
@agriyakhetarpal
Try to run Cython from its pure Python wheel
7efd95d
@agriyakhetarpal
Trigger [pyodide] wheel build, add Cython comment
cfae5ff
@agriyakhetarpal
Move tempita.py to root dir (for now)
3ae370f
@agriyakhetarpal
Bump verbosity for [pyodide] test suite
f16a501
@agriyakhetarpal
Remove spurious missing cache fixture
382c8ba
@agriyakhetarpal
Trigger [pyodide] tests too
049ccca
@agriyakhetarpal
Revert "Move tempita.py to root dir (for now)"
b398144 
This reverts commit 3ae370f.
@agriyakhetarpal
Use find_program function for Tempita
3af4ea2 
and trigger [pyodide] wheel build
@agriyakhetarpal
Clean up test dependencies [pyodide]
4a45a97
@agriyakhetarpal
Move tempita to an inner meson.build
745f6f9
@agriyakhetarpal
Revert "Move tempita to an inner meson.build"
0675412 
This reverts commit 745f6f9.
@agriyakhetarpal
Make tempita usable with find_program()
a9d7e6c 
and trigger [pyodide] wheel builds
@agriyakhetarpal
Add Python shebang to tempita [pyodide]
86247ad 
See numpy/numpy#24971
@agriyakhetarpal
Exclude _build_utils/ from installation
5b4d043
@agriyakhetarpal
Upload [pyodide] wheel artifact for debugging
8acf67e
@agriyakhetarpal
Fix _build_utils/ folder exclusion
ecd3104
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d213a66. Link to the linter CI: here

jeremiedbb
jeremiedbb approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agriyakhetarpal
Copy link
Contributor

Thanks, @lesteve!

@agriyakhetarpal agriyakhetarpal mentioned this pull request Mar 24, 2025
Merged
@ogrisel ogrisel merged commit ade815c into scikit-learn:main Mar 24, 2025
34 checks passed
@lesteve lesteve deleted the meson-tempita-find-program branch March 24, 2025 17:14
@agriyakhetarpal agriyakhetarpal mentioned this pull request Mar 24, 2025
Closed
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Apr 2, 2025
@lesteve @agriyakhetarpal @lucyleeow
MNT Use find_program in meson.build for tempita step (scikit-learn#31058
e4a0a07 
)

Co-authored-by: Agriya Khetarpal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lesteve @agriyakhetarpal @ogrisel @jeremiedbb