Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jeremiedbb
Copy link
Member

  • Made the new behavior the default, i.e. try to match the type of the other columns for the remainder column.
  • Removed the old behavior. The force_int_remainder_cols parameter has no effect anymore. I think this is okay since it was available for 2 releases with a future warning.
  • Deprecated the force_int_remainder_cols param, to be removed in 1.9.

@jeremiedbb jeremiedbb added this to the 1.7 milestone Apr 9, 2025
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d900877. Link to the linter CI: here

@adrinjalali adrinjalali added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Apr 30, 2025
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,4 @@
The `force_int_remainder_cols` parameter of :class:`compose.ColumnTransformer` and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be in bullet form?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, thanks

@lucyleeow lucyleeow merged commit 36d056f into scikit-learn:main May 4, 2025
36 checks passed
@lucyleeow
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:compose Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants