DOC Add link to plot_gmm_pdf.py in GaussianMixture examples #31230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
thank you for your contribution. I would suggest a change in phrasing, to express what is special about this example compared to other examples on GaussianMixture.
Maybe move the link inside the docstring of the score_samples method in sklearn/mixture/_base.py, which is displayed both in GaussianMixture as well as in BaysianGaussianMixture, though it might be worth it. What do you think?
Comment on lines
+707
to
+709
| Gaussian Mixture Models are commonly used for probability density estimation and | ||
| modeling multi-modal distributions. For a visualization, see | ||
| :ref:`sphx_glr_auto_examples_mixture_plot_gmm_pdf.py` |
There was a problem hiding this comment.
I would suggest to directly describe what the example shows. Maybe like this:
Suggested change
| Gaussian Mixture Models are commonly used for probability density estimation and | |
| modeling multi-modal distributions. For a visualization, see | |
| :ref:`sphx_glr_auto_examples_mixture_plot_gmm_pdf.py` | |
| For an illustration of the negative log-likelihood surface of a | |
| :class:`~sklearn.mixture.GaussianMixture` Model, | |
| see :ref:`sphx_glr_auto_examples_mixture_plot_gmm_pdf.py`. |
|
Hi @vivaannanavati123, are you still interested in working on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #30621.
What does this implement/fix? Explain your changes.
plot_gmm_pdf.pyinGaussianMixturedocstring examples to demonstrate density estimation, a key GMM use case missing in API docs.plot_gmm_pdf.pyin API docs.Any other comments?
Noticed that
plot_roc_crossval.pyis already linked in User Guide sections (model_evaluation.rst,cross_validation.rst) and related examples, so I would recommend for it to be checked off.Thank you for your review!