✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 28086a6. Link to the linter CI: here}

Thanks for creating this Pull Request (and getting involved in open-source!).

I think we should handle this via deprecation cycle. This means that code that today uses a negative value will get a warning that in two releases time this will become an invalid value. You can take a look at the section deprecating a parameter of the deprecation guide. We aren't doing exactly the same here, but I think that is the closest example to take inspiration from.

In addition to emitting a warning we need to update the docstrings to mention the deprecation and add a test to check that the warning is (not) raised when it should be.

Thanks for creating this Pull Request (and getting involved in open-source!).

I think we should handle this via deprecation cycle. This means that code that today uses a negative value will get a warning that in two releases time this will become an invalid value. You can take a look at the section deprecating a parameter of the deprecation guide. We aren't doing exactly the same here, but I think that is the closest example to take inspiration from.

In addition to emitting a warning we need to update the docstrings to mention the deprecation and add a test to check that the warning is (not) raised when it should be.

I have made the changes based on your suggestion. Please let me know if this is what you are looking for and if any further changes need to be made.

@betatim I have changed the docstring and added the changelog entry, please let me know if this PR can be merged

@virchan gentle ping to help merge the PR

This is my first contribution, so please let me know if any changes are needed.

@ritvi-alagusankar
Congrats on your first contribution to scikit-learn!
And thank you for addressing this issue, which was opened more than 3 years ago.