-
-
Notifications
You must be signed in to change notification settings - Fork 26k
DOC add link to plot_cv_predict example in cross_val_predict doc #31504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC add link to plot_cv_predict example in cross_val_predict doc #31504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @sisird864! I have a few comments.
- The hash symbols can be removed.
- Please add a blank line between the descriptive text and the Python code.
- "For a detailed example of using
cross_val_predict
to visualize prediction errors, please see <example_link>."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @sisird864! I have a few more comments.
The example you added has split the Python code block in the Examples section in half, which breaks the formatting. Could you please move the text outside the code block?
…864/scikit-learn into docs/link-plot_cv_predict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the PR, @sisird864! I have a few more comments.
For a detailed example of using ``cross_val_predict`` to visualize | ||
prediction errors, please see | ||
:ref:`this example <sphx_glr_auto_examples_model_selection_plot_cv_predict.py>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need "this example" inside :ref:
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you for updating the PR, @sisird864! Just one more nitpick.
Co-authored-by: Virgil Chan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @sisird864!
@adrinjalali, @marenwestermann, would you like to have a look and merge this?
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
This adds a new entry under the “See Also” section of the
cross_val_predict
API docstring insklearn/model_selection/_validation.py
, linking to theplot_cv_predict.py
example: