DOC: Add example link to plot_poisson_regression_non_normal_loss.py in linear_model docs (#30621) #31567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n linear_model docs
There was a problem hiding this comment.
Hi @VirenPassi,
thanks for your work. The problem that I see here is that Ridge in the example only plays the role of a baseline and the example is rather about poisson regression. I therefore think it does not belong into user guide part for RidgeRegression as it doesn't help users who are interested in RidgeRegression. Please understand that I need to therefore close this PR.
We already have a corpus of about 10.000 documentation pages and we really need to be careful about not cluttering it too much.
Let me be clear that your efforts are appreciated, even though I remember that I had to close quite some of your PRs. Hoping it doesn't discourage you. 💚
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #30621
This PR adds a reference to the example
plot_poisson_regression_non_normal_loss.pyunder the Generalized Linear Models section inlinear_model.rst.This allows users to easily find the example illustrating Poisson regression with non-normal loss within the linear model documentation.