Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve whats_new doc #31589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2025
Merged

Conversation

ztw33
Copy link
Contributor

@ztw33 ztw33 commented Jun 19, 2025

Reference Issues/PRs

Issue #31571

What does this implement/fix? Explain your changes.

I found some bugs or unclear areas that need further improvement in several versions of whats_new documentation.

v1.5.0
  • "Deprecates Y in favor of y in the methods fit, transform and inverse_transform of: :class:cross_decomposition.PLSRegression, :class:cross_decomposition.PLSCanonical, :class:cross_decomposition.CCA, and :class:cross_decomposition.PLSSVD."(link) However, classcross_decomposition.PLSSVD doesn‘t seem to have the inverse_transform method (refer to class PLSSVD)
  • "store_cv_values and cv_values_ are deprecated in favor of store_cv_results and cv_results_ in ~linear_model.RidgeCV and ~linear_model.RidgeClassifierCV."(link) I recommend to make it clear that the store_cv_values and cv_values_ are Parameters (like the previous item), otherwise it will be misleading to know whether they are parameters or methods.
v1.4.0
  • ":func:sklearn.extmath.log_logistic is deprecated and will be removed in 1.6. Use -np.logaddexp(0, -x) instead."(link) The full qualified name of function log_logistic should be sklearn.utils.extmath.log_logistic.
v1.3.0
  • "The parameter log_scale in the class :class:model_selection.LearningCurveDisplay has been deprecated in 1.3 and will be removed in 1.5."(link) The deprecated parameter log_scale is actually a parameter of the plot method of the class model_selection.LearningCurveDisplay, not the class constructor. Refer to this.

Any other comments?

@adrinjalali

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5b85114. Link to the linter CI: here

@adrinjalali adrinjalali merged commit d1479da into scikit-learn:main Jun 19, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants