Fix: Replace np.bool_ with np_bool in _ranking.py #31612
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi! This PR replaces deprecated |
Member
StefanieSenger
left a comment
There was a problem hiding this comment.
Hi @MauryaGhogare,
thanks for your efforts. I’m not sure this change is necessary since numpy 1.24 is already quite old (our minimum supported version is 1.22), and we would have seen deprecation warnings if action was needed.
Also this fix causes some tests to fail instead of pass. Given that, I suggest we close this PR for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces deprecated
np.bool_with the compatible internal aliasnp_boolin_ranking.py.This is part of scikit-learn's ongoing cleanup for NumPy compatibility.