Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lucyleeow
Copy link
Member

Reference Issues/PRs

Noticed while working on #31701
follow up to #30886

What does this implement/fix? Explain your changes.

Add more invalid sample weight checks to regression metrics common tests:

  • ensures all values are finite
  • ensure not complex data

Any other comments?

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 979d678. Link to the linter CI: here

Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @lucyleeow!

@virchan virchan added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jul 9, 2025
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lucyleeow

@jeremiedbb jeremiedbb merged commit aed81ed into scikit-learn:main Jul 11, 2025
46 of 47 checks passed
@jeremiedbb jeremiedbb mentioned this pull request Jul 15, 2025
13 tasks
@jeremiedbb jeremiedbb mentioned this pull request Sep 3, 2025
13 tasks
@lucyleeow lucyleeow deleted the test_reg_common branch September 21, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants