Raise error logreg liblinear #31888
Merged
Raise error logreg liblinear #31888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI @antoinebaker |
Contributor
antoinebaker
left a comment
There was a problem hiding this comment.
Thanks for the PR @snath-xoc ! Here a couple nitpicks.
Maybe we should add a changelog entry too ? (as we are raising a new error).
antoinebaker
approved these changes
Sep 30, 2025
doc/whats_new/upcoming_changes/sklearn.linear_model/31888.api.rst
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ogrisel or @adrinjalali perhaps we can review this and merge soon? |
ogrisel
approved these changes
Nov 7, 2025
Member
ogrisel
left a comment
There was a problem hiding this comment.
This might help prevent denial-of-service attacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #7486
What does this implement/fix? Explain your changes.
LogisticRegression freezes when using the liblinear solver with X containing large values>1e30. A ValueError is now raised if X contains a maximum value >1e30 with accompanying tests
Any other comments?
@antoinebaker @yl565 @agramfort @ogrisel