FIX make sure _PassthroughScorer works with meta-estimators #31898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
StefanieSenger
left a comment
There was a problem hiding this comment.
Thanks for the fix and the explanations yesterday, @adrinjalali!
I have looked through the PR and left some suggestions.
Co-authored-by: Stefanie Senger <[email protected]>
Co-authored-by: Stefanie Senger <[email protected]>
Member
Author
|
@OmarManzoor @antoinebaker wanna have a look? Some other PRs depend on this. |
OmarManzoor
approved these changes
Aug 31, 2025
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM thanks @adrinjalali
DeaMariaLeon
pushed a commit
to DeaMariaLeon/scikit-learn
that referenced
this pull request
Sep 12, 2025
…earn#31898) Co-authored-by: Stefanie Senger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30937
The issue was that
_PassthroughScorertries to be smart with metadata-routing info it stores, which only works with simply consumers and not meta estimators (or rather, works when given aMetadataRequestbut notMetadataRouter).This fixes the issue, and improves the implementation in
RidgeCVwhich was arguably not perfect.cc @StefanieSenger @ogrisel @antoinebaker