-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
TST add test_multi_task_lasso_vs_skglm #31957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OmarManzoor
merged 4 commits into
scikit-learn:main
from
lorentzenchr:cd_test_multitask
Aug 19, 2025
Merged
TST add test_multi_task_lasso_vs_skglm #31957
OmarManzoor
merged 4 commits into
scikit-learn:main
from
lorentzenchr:cd_test_multitask
Aug 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virchan
approved these changes
Aug 18, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @lorentzenchr!
OmarManzoor
reviewed
Aug 19, 2025
Contributor
|
LGTM. Enabling auto-merge |
Member
Author
|
@OmarManzoor I think you need to approve first. Then (auto) merge will work. |
OmarManzoor
approved these changes
Aug 19, 2025
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Aug 22, 2025
DeaMariaLeon
pushed a commit
to DeaMariaLeon/scikit-learn
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
In the context of #31956.
What does this implement/fix? Explain your changes.
We don't test against any reference for
MultiTaskLasso.scipy.optimize.minimizeis not able to solve the problem, there this test tests versus skglm.Any other comments?