Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lorentzenchr
Copy link
Member

Reference Issues/PRs

In the context of #31956.

What does this implement/fix? Explain your changes.

We don't test against any reference for MultiTaskLasso. scipy.optimize.minimize is not able to solve the problem, there this test tests versus skglm.

Any other comments?

@github-actions
Copy link

github-actions bot commented Aug 16, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 90e0b35. Link to the linter CI: here

Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @lorentzenchr!

@virchan virchan added the Waiting for Second Reviewer First reviewer is done, need a second one! label Aug 18, 2025
@OmarManzoor OmarManzoor removed the Waiting for Second Reviewer First reviewer is done, need a second one! label Aug 19, 2025
@OmarManzoor
Copy link
Contributor

OmarManzoor commented Aug 19, 2025

LGTM. Enabling auto-merge

@OmarManzoor OmarManzoor enabled auto-merge (squash) August 19, 2025 06:28
@lorentzenchr
Copy link
Member Author

lorentzenchr commented Aug 19, 2025

@OmarManzoor I think you need to approve first. Then (auto) merge will work.

@OmarManzoor OmarManzoor merged commit 3883ba7 into scikit-learn:main Aug 19, 2025
36 checks passed
@lorentzenchr lorentzenchr deleted the cd_test_multitask branch August 19, 2025 17:08
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Aug 22, 2025
@jeremiedbb jeremiedbb mentioned this pull request Sep 3, 2025
13 tasks
DeaMariaLeon pushed a commit to DeaMariaLeon/scikit-learn that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants