-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
ENH improve alignment "?"/"i" and color in HTML diagram #31969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH improve alignment "?"/"i" and color in HTML diagram #31969
Conversation
|
Thank you for your pull request @glemaitre ! 😁 It seems that "single components" names need to be centred when drop-downs are opened: |
|
I think that we already have the bug currently in notebooks only. I made the change here in another PR. But I'll bring the change in this PR then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rendering looks good to me.
I'm not able to assess the quality of the css though.
Maybe @Charlie-XIAO or @thomasjpfan can have a look at the css to check that everything's fine ?
doc/whats_new/upcoming_changes/sklearn.utils/31969.enhancement.rst
Outdated
Show resolved
Hide resolved
….rst Co-authored-by: Jérémie du Boisberranger <[email protected]>
|
The solution I should read the CSS book one day :) |
|
OK so I simplify as suggested and I triggered a documentation build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! This LGTM!






This PR is solving a couple of visual bugs for the "?" and "i" symbols:
sklearn-colorinstead of the IDE background. Therefore, we make sure that it is not varying depending on the theme.main:This PR: