Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH add gap safe screening rules to sparse_ enet_coordinate_descent #31986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OmarManzoor merged 9 commits into from
Sep 5, 2025
Merged

ENH add gap safe screening rules to sparse_ enet_coordinate_descent #31986

OmarManzoor merged 9 commits into from
Sep 5, 2025

Conversation

@lorentzenchr
Copy link
Member

@lorentzenchr lorentzenchr commented Aug 21, 2025

Reference Issues/PRs

Partially solves solves #229.
Continuation of #31882 (which should be merged first!!!)

What does this implement/fix? Explain your changes.

Gap safe screening rules for the Cython funtion sparse_enet_coordinate_descent.

Any other comments?

A bit of refactoring for redundant code.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f8c6736. Link to the linter CI: here

@lorentzenchr lorentzenchr changed the title Gap safe 2 sparse ENH add gap safe screening rules tosparse_ enet_coordinate_descent Aug 21, 2025
@lorentzenchr lorentzenchr changed the title ENH add gap safe screening rules tosparse_ enet_coordinate_descent ENH add gap safe screening rules to sparse_ enet_coordinate_descent Aug 21, 2025
@lorentzenchr lorentzenchr mentioned this pull request Aug 22, 2025
Closed
@lorentzenchr lorentzenchr mentioned this pull request Aug 25, 2025
Merged
@lorentzenchr lorentzenchr added this to the 1.8 milestone Aug 25, 2025
OmarManzoor
OmarManzoor approved these changes Aug 31, 2025
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lorentzenchr

@OmarManzoor OmarManzoor added the Waiting for Second Reviewer First reviewer is done, need a second one! label Aug 31, 2025
OmarManzoor
OmarManzoor reviewed Sep 2, 2025
View reviewed changes
virchan
virchan approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @lorentzenchr!

@OmarManzoor, could we merge this?

@OmarManzoor OmarManzoor merged commit 91d5640 into scikit-learn:main Sep 5, 2025
40 checks passed
@lorentzenchr lorentzenchr deleted the gap_safe_2_sparse branch September 5, 2025 06:36
DeaMariaLeon pushed a commit to DeaMariaLeon/scikit-learn that referenced this pull request Sep 12, 2025
@lorentzenchr @DeaMariaLeon
ENH add gap safe screening rules to sparse_ enet_coordinate_descent (s…
40a9962 
…cikit-learn#31986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmarManzoor OmarManzoor OmarManzoor approved these changes

+1 more reviewer

@virchan virchan virchan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cython module:linear_model Performance Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Milestone

1.8

Development

Successfully merging this pull request may close these issues.

3 participants

@lorentzenchr @OmarManzoor @virchan