DOC Make sure all parameter tables use the same font #32144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Sep 15, 2025
virchan
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
I've compared the results on the Selecting dimensionality reduction with Pipeline and GridSearchCV example.
LGTM as well! Thanks, @jeremiedbb!
@glemaitre, could we merge this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the parameter table of the outermost meta-estimator may have a different font size, see the grid search vs logistic regression below
It happens because font-family is set on the
sk-estimatorclass but the outermost meta-estimator is not. The most robust way seems to set the font-family onestimator-table.ping @glemaitre