DOC Improve explanation of candidate split thresholds in decision trees #32180
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virchan
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Thank you for the PR, @raixyzaditya, and for helping improve scikit-learn.
After reviewing the changes, it seems the instruction in #27159 (comment) may not have been fully understood here. If you are still interested in contributing to this issue, I would strongly recommend carefully (re-)reading the linked comment to clarify what is expected.
With that said, I'm closing this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of candidate thresholds per feature depends on the number of unique values:
.) n_unique - 1 if no missing values
.) 2 × n_unique - 1 if there are missing values
I’ll update the note to reflect this so it’s more accurate than just saying O(N × F).