WIP - POC for fixing dark mode HTML diagrams rendering #32199
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using Dark High Contrast theme on vscode, with this PR, we can go from to: The css needs some more work, but I wonder if I should keep working on this as the preferred solution may still be to use javascript. edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #30357
What does this implement/fix? Explain your changes.
The latest comments of the issue I mention above, it's suggested to use javascript as in skrub.
This is a POC of an easy solution as another option. The reason being that adding javascript, forces us to also test it.
Here are the packages used to do that in skrub: Testing the javascript code
Also, from the same page I just linked: "... the report is placed in a shadow DOM, which insulates it from the surrounding css and javascript."
So, we may need to do that as well to really fix these kind of issues.
Talking to @glemaitre, we agree that at some point we need to test javascript in scikit-learn's ci. So, this PR may be a temporary solution if it's accepted.
Any other comments?