FIX test failures in test_sparse_pca.py
#32221
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_fit_transform test_fit_transform_tall
virchan
approved these changes
Sep 20, 2025
There was a problem hiding this comment.
LGTM! Thank you for the PR, @marenwestermann!
If you'd like to use a tighter tolerance for test_fit_transform, then rtol=5e-4, atol=2e-4 should also work.
P.S. It feels great to finally be able to assist you on a PR 😄.
|
@jeremiedbb, would you like to have a look? |
|
I know this fixes the issue, but 1e-3 is kinda quite large. I wonder if it's expected that @lorentzenchr do you happen to know if this is normal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #32214 and #32184
What does this implement/fix? Explain your changes.
This is a quick fix for addressing recent CI failures. For fixing the failures I increased the tolerances. I think the tolerances are still low enough but please correct me if I'm wrong.
Any other comments?