Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

dkobak
Copy link
Contributor

@dkobak dkobak commented Sep 20, 2025

This is a follow-up to #31322 that added a classical MDS implementation as ClassicalMDS class. As discussed over there, this PR does the following:

  1. It adds support for non-Euclidean metrics to the MDS class, following example of ClassicalMDS.
  2. It changes the API of MDS to make it consistent with ClassicalMDS and other sklearn classes: distance metric is now set via the metric argument, and metric/non-metric MDS can be toggled via metric_mds=True/False argument. Backwards compatibility is ensured for the next scikit-learn versions.
  3. Classical MDS is added as an initialization option to the MDS class, to be made default in the future.

PS. Apologies for lots of obsolete commits here :-( Just ignore them.

Copy link

github-actions bot commented Sep 20, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d8420c3. Link to the linter CI: here

@dkobak
Copy link
Contributor Author

dkobak commented Sep 20, 2025

@antoinebaker As promised, now that my Classical MDS PR has been merged, I prepared a follow-up PR to modify the MDS class accordingly. Would be great if you could take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant