-
-
Notifications
You must be signed in to change notification settings - Fork 26.3k
FEA Add support for arbitrary metrics and informative initialization to MDS #32229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkobak
wants to merge
43
commits into
scikit-learn:main
Choose a base branch
from
dkobak:mds-init-and-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: antoinebaker <[email protected]>
Co-authored-by: Adrin Jalali <[email protected]>
Co-authored-by: antoinebaker <[email protected]>
@antoinebaker As promised, now that my Classical MDS PR has been merged, I prepared a follow-up PR to modify the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #31322 that added a classical MDS implementation as
ClassicalMDS
class. As discussed over there, this PR does the following:MDS
class, following example ofClassicalMDS
.MDS
to make it consistent withClassicalMDS
and other sklearn classes: distance metric is now set via themetric
argument, and metric/non-metric MDS can be toggled viametric_mds=True/False
argument. Backwards compatibility is ensured for the next scikit-learn versions.MDS
class, to be made default in the future.PS. Apologies for lots of obsolete commits here :-( Just ignore them.