-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
Add array API support to precision_recall_curve
#32249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests fail on torch because it does not support negative indexing (data-apis/array-api-compat#144, pytorch/pytorch#59786) - it seems we could use flip but that creates a copy...? Seems unlikely to change?
Not sure if there is a standard workaround for this? Or do we need to re-write to avoid negative indexing? Or skip for torch...? Edit: scipy uses flip, even though it creates a copy, but shouldn't be too bad in this case, and does not seem like there is anything else we can do so 🤷 |
|
cc @OmarManzoor @virchan @betatim in case someone is interested to review |
OmarManzoor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Thanks for the PR @lucyleeow
OmarManzoor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the review @OmarManzoor ! |
virchan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @lucyleeow!
@OmarManzoor, could we merge this?
|
Thank you for the reviews! |
Reference Issues/PRs
Towards #26024
What does this implement/fix? Explain your changes.
Add array API support to
precision_recall_curveAny other comments?