-
-
Notifications
You must be signed in to change notification settings - Fork 26.3k
FEAT allow RFE(CV) be used with pemutation_importance
#32251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GaetandeCast
wants to merge
10
commits into
scikit-learn:main
Choose a base branch
from
GaetandeCast:RFE-permut
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
eb67d47
base logic and test
GaetandeCast 55db7fb
dont inspect signature for attrgetter to avoid python3.10 bug
GaetandeCast e9a58bc
add changelog
GaetandeCast 5777a4a
add test from code review
GaetandeCast f2bf623
doc example and docstrings
GaetandeCast 701e6a6
typo and reformulation
GaetandeCast a7897d3
add missing backtick and colon
GaetandeCast db66df6
typo
GaetandeCast 3854954
improve docstring and fix example
GaetandeCast a6ed721
improve documentation
GaetandeCast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
doc/whats_new/upcoming_changes/sklearn.feature_selection/32251.feature.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
- :class:`feature_selection.RFE` and :class:`feature_selection.RFECV` | ||
now support the use of :func:`permutation_importance` as an :attr:`importance_getter`. | ||
When a callable, and when possible, the :attr:`importance_getter` is passed | ||
:attr:`feature_indices` along with the fitted estimator. | ||
The attribute :attr:`feature_indices` stores the index of the features from the full dataset | ||
that have not been eliminated yet. | ||
This allows methods that need a test set, like :func:`permutation_importance`, to know which | ||
features to use in their predictions. | ||
By :user:`Gaétan de Castellane <GaetandeCast>`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a
.. versionchanged:: 1.8
and mention that support for passingfeature_indices
to the callable when part of its signature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And similarly for the docstring of the other class.