MNT Clean-up deprecations for 1.8: algorithm param in AdaBoostClassifier #32262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Sep 24, 2025
sklearn/ensemble/_weight_boosting.py
Outdated
| **BaseWeightBoosting._parameter_constraints, | ||
| "algorithm": [StrOptions({"SAMME"}), Hidden(StrOptions({"deprecated"}))], | ||
| } | ||
| _parameter_constraints: dict = {**BaseWeightBoosting._parameter_constraints} |
There was a problem hiding this comment.
Then we can simply remove this, right?
There was a problem hiding this comment.
Ah yes indeed, I did not pay attention. Since all the parameters are fed to the parent class, they will get validated in the parent init, right ?
There was a problem hiding this comment.
They get validated in the decorator around fit, which would use the values from the parent class (right @jeremiedbb ?)
There was a problem hiding this comment.
Ah yes it's a class attribute so it will simply inherit the one from its parent and use it.
|
I'd also push a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Clean up for the deprecation from #29997.
What does this implement/fix? Explain your changes.
Remove the
algorithmparam ofsklearn.ensemble.AdaBoostClassifier.