Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FEA Add array API support for cross_val_predict #32270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

FEA Add array API support for cross_val_predict #32270

wants to merge 7 commits into from
+67 −4

Conversation

OmarManzoor
Copy link
Contributor

@OmarManzoor OmarManzoor commented Sep 25, 2025 •
edited
Loading

Reference Issues/PRs

No direct issue but related to #26024. Also PR #32246 depends on this.

What does this implement/fix? Explain your changes.

  • Ensures that cross_val_predict functions correctly with the array API

Any other comments?

@OmarManzoor OmarManzoor marked this pull request as ready for review September 25, 2025 10:04
OmarManzoor
OmarManzoor commented Sep 25, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a1ecd29. Link to the linter CI: here

@github-actions github-actions bot removed the CUDA CI label Sep 25, 2025
ogrisel
ogrisel approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

OmarManzoor
OmarManzoor commented Sep 25, 2025
View reviewed changes
@github-actions github-actions bot removed the CUDA CI label Sep 25, 2025
@github-actions github-actions bot removed the CUDA CI label Sep 25, 2025
@OmarManzoor
Copy link
Contributor Author

OmarManzoor commented Sep 25, 2025 •
edited
Loading

Re-triggered CUDA CI because the unit tests were failing because of weird CUDA errors.

@OmarManzoor OmarManzoor reopened this Sep 25, 2025
@github-actions github-actions bot removed the CUDA CI label Sep 25, 2025
virchan
virchan approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @OmarManzoor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

+1 more reviewer

@virchan virchan virchan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Array API module:metrics module:model_selection module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmarManzoor @ogrisel @virchan