FIX Decision/Extra trees: fix handling of missing values in detection of constant features #32274
+31
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #32272
What does this implement/fix? Explain your changes.
Simple fix of the if-condition detecting constant features.
Any other comments?
I'm not willing to write a lot of tests in this PR, as I'd rather move forward on this testing-focused PR instead: #32193
Indeed it's the test from this PR that made me find this bug (and also detected two other bugs) while not being aimed at finding this bug precisely (nor any of the two others). Which, IMO, proves it's a better test (for split logic correctness) than tests that are already present, and better than toy examples.