[MRG+1] Use the Gram Variant when precompute is True #3247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, +1 for merge. @agramfort already gave a +1 for this in the parent PR so I think we can merge. This bug was present in 0.14.1 I think, do you confirm @MechCoder? If so I will add a whats new entry when I merge. |
|
add what's new then merge |
|
Done! Thanks @MechCoder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm
cd_fast.enet_coordinate_descent_gramis unused even when.a] precompute is True
b] precompute is "auto" and n_samples >> n_features.
This PR fixes this issue.