Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add array API support to calinski_harabasz_score #32600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucyleeow merged 9 commits into from
Nov 8, 2025
Merged

Add array API support to calinski_harabasz_score #32600

lucyleeow merged 9 commits into from
Nov 8, 2025

Conversation

@jaffourt
Copy link
Contributor

@jaffourt jaffourt commented Oct 28, 2025

Reference Issues/PRs

Towards #26024

What does this implement/fix? Explain your changes.

Add array API support to calinski_harabasz_score

Any other comments?

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 04aacdd. Link to the linter CI: here

jaffourt
jaffourt commented Oct 28, 2025
View reviewed changes
jaffourt
jaffourt commented Oct 28, 2025
View reviewed changes
@ogrisel ogrisel moved this to Todo in Array API Oct 30, 2025
@ogrisel ogrisel moved this from Todo to In Progress in Array API Oct 30, 2025
lucyleeow
lucyleeow reviewed Oct 31, 2025
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments other LGTM!

@lucyleeow lucyleeow added the Waiting for Second Reviewer First reviewer is done, need a second one! label Oct 31, 2025
@lucyleeow lucyleeow mentioned this pull request Nov 6, 2025
Open
OmarManzoor
OmarManzoor reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @jaffourt

@OmarManzoor OmarManzoor removed the Waiting for Second Reviewer First reviewer is done, need a second one! label Nov 7, 2025
@github-actions github-actions bot removed the CUDA CI label Nov 7, 2025
@github-actions github-actions bot removed the CUDA CI label Nov 8, 2025
OmarManzoor
OmarManzoor reviewed Nov 8, 2025
View reviewed changes
@github-actions github-actions bot removed the CUDA CI label Nov 8, 2025
OmarManzoor
OmarManzoor approved these changes Nov 8, 2025
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @jaffourt

lucyleeow
lucyleeow approved these changes Nov 8, 2025
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@lucyleeow lucyleeow merged commit 0cf4326 into scikit-learn:main Nov 8, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Array API Nov 8, 2025
@lucyleeow lucyleeow mentioned this pull request Nov 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmarManzoor OmarManzoor OmarManzoor approved these changes

@lucyleeow lucyleeow lucyleeow approved these changes

+1 more reviewer

@jaffourtit-od jaffourtit-od jaffourtit-od left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Array API module:metrics

Projects

Array API
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaffourt @OmarManzoor @lucyleeow @jaffourtit-od