FEA Add array API support for laplacian_kernel
#32613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laplacian_kernel
OmarManzoor
approved these changes
Oct 30, 2025
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thank you @zubairshakoorarbisoft
Within the array_api.rst metrics list we can remove the additional comment in brackets from sklearn.metrics.pairwise.pairwise_kernels as that is not applicable anymore.
- :func:
sklearn.metrics.pairwise.pairwise_kernels(supports allsklearn.pairwise.PAIRWISE_KERNEL_FUNCTIONSexcept :func:sklearn.metrics.pairwise.laplacian_kernel)
lucyleeow
approved these changes
Oct 31, 2025
Member
lucyleeow
left a comment
There was a problem hiding this comment.
LGTM, just @OmarManzoor's comment to fix.
rouk1
pushed a commit
to rouk1/scikit-learn
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs:
Towards: #26024
What does this implement/fix? Explain your changes:
Add array API support for
sklearn.metrics.laplacian_kernel