-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
MNT Deprecate n_jobs in LogisticRegression #32742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Deprecate n_jobs in LogisticRegression #32742
Conversation
adrinjalali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
sklearn/linear_model/_logistic.py
Outdated
| "value > 1e30 results in a frozen fit. Please choose another " | ||
| "solver or rescale the input X." | ||
| ) | ||
| # TODO(lesteve) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you sure you want to be the only one qualified to handle this at some point in the future? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 good catch actually I meant to remove the code after this marker 😉, which I have now done
jeremiedbb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Sorry didn't mean to merge. I think it misses a changelog entry. |
|
I opened #32746 to add it |
Fix #32739