Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Nov 19, 2025

Fix #32739

@lesteve lesteve added Quick Review For PRs that are quick to review and removed module:linear_model labels Nov 19, 2025
@lesteve lesteve added this to the 1.8 milestone Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: ec021f4. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

"value > 1e30 results in a frozen fit. Please choose another "
"solver or rescale the input X."
)
# TODO(lesteve)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure you want to be the only one qualified to handle this at some point in the future? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 good catch actually I meant to remove the code after this marker 😉, which I have now done

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb jeremiedbb merged commit 1a288c6 into scikit-learn:main Nov 19, 2025
38 checks passed
@jeremiedbb
Copy link
Member

Sorry didn't mean to merge. I think it misses a changelog entry.

@jeremiedbb
Copy link
Member

I opened #32746 to add it

@lesteve lesteve deleted the deprecate-logisticregression-n-jobs branch November 20, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Changelog Needed Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate n_jobs in LogisticRegression

3 participants