Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Dec 3, 2025

Looking at the changelog and release highlights #30763 is not mentioned. Since this is the one that adds parameters to HTML repr, this is a bit of a shame.

For completeness:

  • this way is a bit hacky but works fine: you add manually a :pr: with the right PR and the second PR is based on the number inside the filename. I noticed @lorentzenchr did it and that's actually a good idea!
  • I think towncrier has a way to do something similar where you need to add the exact same changelog text in two different files and they will be grouped in the same changelog entry (they need to be in the same category e.g. enhancement otherwise it's not grouped). IMO this is too complicated so let's do it the simple manual way.

@lesteve lesteve added Quick Review For PRs that are quick to review and removed Documentation labels Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a1447c1. Link to the linter CI: here

@lesteve lesteve added this to the 1.8 milestone Dec 3, 2025
@lesteve
Copy link
Member Author

lesteve commented Dec 3, 2025

rendered doc looks good:
image

@github-actions github-actions bot added the CI:Linter failure The linter CI is failing on this PR label Dec 4, 2025
@github-actions github-actions bot removed the CI:Linter failure The linter CI is failing on this PR label Dec 4, 2025
@lorentzenchr
Copy link
Member

@lesteve You can merge whenever you like. I checked the rendered changelog, seems fine.

@lesteve lesteve merged commit 4a10d0e into scikit-learn:main Dec 4, 2025
39 checks passed
@lesteve
Copy link
Member Author

lesteve commented Dec 4, 2025

Thanks, merging my own PR with one approval!

@lesteve lesteve mentioned this pull request Dec 4, 2025
7 tasks
lesteve added a commit to lesteve/scikit-learn that referenced this pull request Dec 9, 2025
@lesteve lesteve mentioned this pull request Dec 9, 2025
14 tasks
lesteve added a commit to lesteve/scikit-learn that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants