Implement "everything follows X" for GridSearchCV - #33633
Conversation
|
Refreshed this PR. It is more of a small fix now then really implementing something new. Could be an easy review. |
virchan
left a comment
There was a problem hiding this comment.
LGTM! Thanks, @betatim!
@OmarManzoor, would you like to have a look and merge this?
|
@betatim there is one failing test. Could you please check? |
|
The failure happened because we use I added a new combination of "numpy" -> "cupy" to the mixed namespace test generator. This would have caught this bug before. But I could be convinced that we are starting down a slippery slope of combinatorics by doing this. The |
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thank you @betatim
I think this is very reasonable. When we made the initial list, it was a best guess at what would encompass "all" cases. |
What does this implement/fix? Explain your changes.
This implements the "everything follows X" story for
GridSearchCV.Noticed that this estimator doesn't do that and it looked like an easy fix.
A downside is that I added a "custom" test to check it works which will be redundant once we merge #33525
AI usage disclosure
I used AI assistance for: