ENH add newton-cg solver to GLM like PoissonRegressor - #33759
Merged
Conversation
lorentzenchr
force-pushed
the
newton_cg_glm
branch
from
April 27, 2026 19:14
119b8b3 to
15ebc40
Compare
Member
Author
|
@virchan @OmarManzoor This might interest you. |
virchan
approved these changes
Jun 12, 2026
virchan
left a comment
Member
There was a problem hiding this comment.
LGTM! Just some minor issue with the version number. Thanks, @lorentzenchr!
Co-authored-by: Virgil Chan <[email protected]>
OmarManzoor
approved these changes
Jun 15, 2026
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @lorentzenchr
Only suggested a few doc improvements
OmarManzoor
enabled auto-merge (squash)
June 16, 2026 11:52
Member
Author
|
@virchan @OmarManzoor It is a real pleasure to work with you both! |
Contributor
Thank you. Your PRs are really good! |
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
…3759) Co-authored-by: Virgil Chan <[email protected]> Co-authored-by: Omar Salman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Solves #16635.
What does this implement/fix? Explain your changes.
This PR add the
solver="newton-cg"toPoissonRegressorGammaRegressorTweedieRegressorAI usage disclosure
None
Any other comments?
This is a good solver when
Xis sparse or whenXhas many features.Newton-CG could turn out to be very easy to make Array API compliant, see #33765.