MNT remove get_columns/callable in set_output - #34079
Merged
Merged
Conversation
thomasjpfan
approved these changes
Jun 8, 2026
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
In the original version, columns was callable so that it is not called during "wrapping time".
Looking at the code now, this simplification works. lgtm
Member
Author
|
@thomasjpfan Wanna merge? It has zero user impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
Small maintenance in
sklearn.utils._set_output.AI usage disclosure
None
Any other comments?
At first sight, set_output seemed like a good place to use narwhals. After a closer look, I would leave it as is.