ENH improve linesearch of NewtonSolver - #34157
Merged
Merged
Conversation
Member
Author
|
@ogrisel You mentioned you found some corner cases where the current code has regressions. Could you point me to the places where it goes wrong or provide the examples? |
Member
Author
|
@virchan @OmarManzoor This might also interest you. |
OmarManzoor
reviewed
Jun 16, 2026
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
Only a few minor comments otherwise looks good. Thank you @lorentzenchr
OmarManzoor
approved these changes
Jun 17, 2026
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for this nice PR @lorentzenchr
OmarManzoor
reviewed
Jun 19, 2026
Co-authored-by: Omar Salman <[email protected]>
prady0t
pushed a commit
to prady0t/scikit-learn
that referenced
this pull request
Sep 2, 2026
Co-authored-by: Omar Salman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
This PR improves the line search of the "newton-cholesky" solver.
Instead of decreasing the step size by a factor of 0.5, it now uses quadratic of cubic polynomial interpolation to find the next step size.
AI usage disclosure
None
Any other comments?