Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Document rich dependency for ProgressBar - #34168

Merged
jeremiedbb merged 3 commits into
scikit-learn:mainfrom
heyyveer:main
Jun 3, 2026
Merged

DOC Document rich dependency for ProgressBar#34168
jeremiedbb merged 3 commits into
scikit-learn:mainfrom
heyyveer:main

Conversation

@heyyveer

@heyyveer heyyveer commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #34166

What does this implement/fix? Explain your changes.

Added a note to the ProgressBar docstring documenting that the callback requires the rich package to be installed.

AI usage disclosure

I used AI assistance for:

  • Documentation (including examples)
  • Research and understanding

Any other comments?

This is a documentation-only change.

@StefanieSenger StefanieSenger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @heyyveer.

@jeremiedbb jeremiedbb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @heyyveer. Just a suggestion.

Comment thread sklearn/callback/_progressbar.py Outdated
Co-authored-by: Jérémie du Boisberranger <[email protected]>

@Abdeltoto Abdeltoto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. The note is scoped to the \ProgressBar\ docstring as requested in #34166, and the wording now matches the reviewer suggestion.

@jeremiedbb
jeremiedbb merged commit a845acd into scikit-learn:main Jun 3, 2026
38 checks passed
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
14 tasks
jeremiedbb added a commit that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Callbacks Documentation Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC Progressbar requires to install rich

4 participants