Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix metadata routed to correct consumer in BaggingClassifier.predict_proba - #34188

Merged
adrinjalali merged 1 commit into
scikit-learn:mainfrom
StefanieSenger:fix_baggingclassifier_metadata_routing
Jun 3, 2026
Merged

Fix metadata routed to correct consumer in BaggingClassifier.predict_proba#34188
adrinjalali merged 1 commit into
scikit-learn:mainfrom
StefanieSenger:fix_baggingclassifier_metadata_routing

Conversation

@StefanieSenger

Copy link
Copy Markdown
Member

Reference Issues/PRs

discovered while working on #34179

What does this implement/fix? Explain your changes.

This fixes a bug where metadata was not routed to the correct underlying consuming function when consuming function is dynamically selected. This makes the repaired tests in #34179 pass.

AI usage disclosure

I used AI assistance for:

  • Research and understanding

CC @adrinjalali :)

@StefanieSenger StefanieSenger added the Metadata Routing all issues related to metadata routing, slep006, sample props label Jun 3, 2026
@StefanieSenger StefanieSenger moved this to To Review in Metadata routing Jun 3, 2026
@StefanieSenger StefanieSenger changed the title Fix metadata routed wrongly in BaggingClassifier.predict_proba Fix metadata routed to correct consumer in BaggingClassifier.predict_proba Jun 3, 2026
@adrinjalali
adrinjalali enabled auto-merge (squash) June 3, 2026 12:10
@adrinjalali
adrinjalali merged commit 802d917 into scikit-learn:main Jun 3, 2026
45 checks passed
@github-project-automation github-project-automation Bot moved this from To Review to Done in Metadata routing Jun 3, 2026
@StefanieSenger
StefanieSenger deleted the fix_baggingclassifier_metadata_routing branch June 3, 2026 12:43
@StefanieSenger

Copy link
Copy Markdown
Member Author

Thanks, @adrinjalali , but arg, we forgot the changelog. I will add it in 34188 then.

StefanieSenger added a commit to StefanieSenger/scikit-learn that referenced this pull request Jun 3, 2026
@github-project-automation github-project-automation Bot moved this to Done in Labs Jun 5, 2026
prady0t pushed a commit to prady0t/scikit-learn that referenced this pull request Sep 2, 2026
@jeremiedbb jeremiedbb mentioned this pull request Sep 8, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Metadata Routing all issues related to metadata routing, slep006, sample props module:ensemble

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants